fix(kotlin-client): use enum value in query (#18236) #22929

Tooa · 2026-02-09T16:20:02Z

This commit fixes an issue where enums are used as a value in either path or query params due to relying on string casting. With this change, enum values are requested by using .value instead.

I also used kotlin string interpolation to address one of the AI review feedback comments. The change is in line with the multiplatform implementation.

Scope: This MR just fixes issues with scalar enums.

Related to #18236.

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package || exit
./bin/generate-samples.sh ./bin/configs/*.yaml || exit
./bin/utils/export_docs_generators.sh || exit
```
(For Windows users, please run the script in WSL)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fix Kotlin client query parameter handling to use enum.value and Kotlin string interpolation in jvm-spring-restclient and jvm-spring-webclient templates. This ensures correct URL serialization for enums and other values and prevents invalid requests.

^{Written for commit 09ffa40. Summary will update on new commits.}

cubic-dev-ai

2 issues found across 2 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache:106">
P2: Enum query parameters now pass raw `.value` into `listOf(...)`, which breaks the `List<String>` type when enum values are non-String (e.g., Int). Generated clients will not compile for such enums.</violation>
</file>

<file name="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache:104">
P2: Container enum query parameters still serialize via toMultiValue’s default toString() converter, so list/array enums will continue to send enum names instead of their .value. The fix only handles scalar enums and leaves container enums unchanged.</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

...enapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache

cubic-dev-ai · 2026-02-09T16:26:32Z

...napi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache

                {{^required}}
                if ({{{paramName}}} != null) {
-                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{{paramName}}}.toString(){{/isDate}}{{/isDateTime}}){{/isContainer}})
+                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}{{{paramName}}}.value{{/isEnumOrRef}}{{^isEnumOrRef}}{{{paramName}}}.toString(){{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}})


P2: Container enum query parameters still serialize via toMultiValue’s default toString() converter, so list/array enums will continue to send enum names instead of their .value. The fix only handles scalar enums and leaves container enums unchanged.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache, line 104: <comment>Container enum query parameters still serialize via toMultiValue’s default toString() converter, so list/array enums will continue to send enum names instead of their .value. The fix only handles scalar enums and leaves container enums unchanged.</comment> <file context> @@ -101,17 +101,17 @@ import {{packageName}}.infrastructure.* {{^required}} if ({{{paramName}}} != null) { - put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{{paramName}}}.toString(){{/isDate}}{{/isDateTime}}){{/isContainer}}) + put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}{{{paramName}}}.value{{/isEnumOrRef}}{{^isEnumOrRef}}{{{paramName}}}.toString(){{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}}) } {{/required}} </file context>

From my understanding container enums are also broken in other implementations (e.g. multiplatform) as well. Might focus on scalar enums in this MR for now. The fix is already an improvement.

cubic-dev-ai

2 issues found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache:104">
P2: Enum collections in query parameters are still serialized using toString via toMultiValue, so enum arrays/lists send enum names instead of the enum value, inconsistent with scalar enum handling.</violation>
</file>

<file name="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache:106">
P2: List/array enum query params still serialize via toMultiValue’s default `$item` conversion, which uses enum name rather than the enum `value`, causing inconsistent and potentially incorrect query values compared to scalar enums.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-02-09T17:46:45Z

...napi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache

                {{^required}}
                if ({{{paramName}}} != null) {
-                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{{paramName}}}.toString(){{/isDate}}{{/isDateTime}}){{/isContainer}})
+                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}"${{{paramName}}}.value}"{{/isEnumOrRef}}{{^isEnumOrRef}}"${{{paramName}}}"{{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}})


P2: Enum collections in query parameters are still serialized using toString via toMultiValue, so enum arrays/lists send enum names instead of the enum value, inconsistent with scalar enum handling.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache, line 104: <comment>Enum collections in query parameters are still serialized using toString via toMultiValue, so enum arrays/lists send enum names instead of the enum value, inconsistent with scalar enum handling.</comment> <file context> @@ -101,17 +101,17 @@ import {{packageName}}.infrastructure.* {{^required}} if ({{{paramName}}} != null) { - put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}{{{paramName}}}.value{{/isEnumOrRef}}{{^isEnumOrRef}}{{{paramName}}}.toString(){{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}}) + put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}"${{{paramName}}}.value}"{{/isEnumOrRef}}{{^isEnumOrRef}}"${{{paramName}}}"{{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}}) } {{/required}} </file context>

cubic-dev-ai · 2026-02-09T17:46:45Z

...enapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache

                {{^required}}
                if ({{{paramName}}} != null) {
-                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{{paramName}}}.toString(){{/isDate}}{{/isDateTime}}){{/isContainer}})
+                    put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}"${{{paramName}}}.value}"{{/isEnumOrRef}}{{^isEnumOrRef}}"${{{paramName}}}"{{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}})


P2: List/array enum query params still serialize via toMultiValue’s default $item conversion, which uses enum name rather than the enum value, causing inconsistent and potentially incorrect query values compared to scalar enums.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache, line 106: <comment>List/array enum query params still serialize via toMultiValue’s default `$item` conversion, which uses enum name rather than the enum `value`, causing inconsistent and potentially incorrect query values compared to scalar enums.</comment> <file context> @@ -103,17 +103,17 @@ import {{packageName}}.infrastructure.* {{^required}} if ({{{paramName}}} != null) { - put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}{{{paramName}}}.value{{/isEnumOrRef}}{{^isEnumOrRef}}{{{paramName}}}.toString(){{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}}) + put("{{baseName}}", {{#isContainer}}toMultiValue({{{paramName}}}.toList(), "{{collectionFormat}}"){{/isContainer}}{{^isContainer}}listOf({{#isDateTime}}parseDateToQueryString({{{paramName}}}){{/isDateTime}}{{#isDate}}parseDateToQueryString({{{paramName}}}){{/isDate}}{{^isDateTime}}{{^isDate}}{{#isEnumOrRef}}"${{{paramName}}}.value}"{{/isEnumOrRef}}{{^isEnumOrRef}}"${{{paramName}}}"{{/isEnumOrRef}}{{/isDate}}{{/isDateTime}}){{/isContainer}}) } {{/required}} </file context>

Tooa · 2026-02-09T17:47:31Z

I am done from my side for now. Let me know if you want anything changed.

fix(kotlin-client): use enum value in query

a6dfe6b

cubic-dev-ai bot reviewed Feb 9, 2026

View reviewed changes

fix: usestring interpolation

09ffa40

cubic-dev-ai bot reviewed Feb 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(kotlin-client): use enum value in query (#18236) #22929

fix(kotlin-client): use enum value in query (#18236) #22929

Tooa commented Feb 9, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading

Uh oh!

Tooa Feb 9, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading

Uh oh!

Tooa commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

fix(kotlin-client): use enum value in query (#18236) #22929

Are you sure you want to change the base?

fix(kotlin-client): use enum value in query (#18236) #22929

Conversation

Tooa commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tooa Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tooa commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Tooa commented Feb 9, 2026 •

edited

Loading

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading

cubic-dev-ai bot Feb 9, 2026 •

edited

Loading